Add CI package pipeline for building and publishing NuGet packages#4292
Add CI package pipeline for building and publishing NuGet packages#4292paulmedynski wants to merge 7 commits into
Conversation
paulmedynski
changed the base branch from
main
to
dev/paul/sql-server-project-refs
paulmedynski
added
the
Area\Engineering
There was a problem hiding this comment.
Pull request overview
Adds a new CI pipeline that builds and publishes NuGet packages via build.proj in ReferenceType=Package mode, alongside a broader refactor to make package-mode builds self-sustaining: version flow is unified through import-guarded Versions.props files imported early by Directory.Packages.props, all Pack* targets now mirror their output into the local packages/ feed and gain DependsOn chains so dependent packages restore against freshly built nupkgs, and many test/csproj files now switch between ProjectReference and PackageReference for Microsoft.SqlServer.Server based on ReferenceType. A new signed test category gates UDT tests that require a strong-name-signed Microsoft.SqlServer.Server.
Changes:
- New pipeline
eng/pipelines/ci/package/sqlclient-package.yml(push tomain/internal/main, nightly, optional strong-name signing on internal builds). build.projandDirectory.Packages.propsoverhaul: package-modeDependsOn/Pack mirroring, centralSqlServerPackageVersiontoken wiring,category!=signedfilter for unsigned builds.- Threading of
sqlServerArtifactsName/sqlServerPackageVersionthrough existing CI templates, and reference-mode switching forMicrosoft.SqlServer.Serveracross csprojs (including nuspec token$SqlServerPackageVersion$).
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/ci/package/sqlclient-package.yml | New CI pipeline that packs all packages and publishes Packages artifact. |
| build.proj | Adds package-mode DependsOn chains, output mirroring to packages/, category!=signed filter, and PackageVersionSqlServer threading. |
| Directory.Packages.props | Imports all Versions.props in Package mode to centrally manage sibling package versions. |
| doc/Directory.Packages.props, doc/samples/Microsoft.Data.SqlClient.Samples.csproj | Pin and reorganize Microsoft.SqlServer.Server package usage. |
| src/Directory.Build.props | Comment clarifying FileVersionBuildNumber ordering relative to Directory.Packages.props. |
| src/**/Versions.props (×6) | Add per-product import-guard property to prevent double evaluation. |
| src/**/*.csproj (Logging, Abstractions, Azure, AKV, SqlServer, SqlClient src/ref/notsupported) | Conditional Versions.props import using the new guard; SqlClient ref/notsupported gain SqlServer reference; nuspec token updated. |
| src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj | Adds SqlServer version import, trim, validation error, and nuspec token replacement. |
| src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.nuspec | Replaces hard-coded 1.0.0 with $SqlServerPackageVersion$ token. |
| src/Microsoft.Data.SqlClient/tests/UnitTests/...csproj | Adds ValidateReferenceType target and project reference to Microsoft.SqlServer.Server. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/...csproj | Reference-mode switching for Microsoft.SqlServer.Server (top-level and UDT projects). |
| src/Microsoft.Data.SqlClient/tests/Common/Microsoft.Data.SqlClient.TestCommon.csproj | Enables ImplicitUsings. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/SqlServerTypesTest.cs, FunctionalTests/SqlDataRecordTest.cs | Adds [Trait("Category", "signed")] on NETFRAMEWORK for UDT tests requiring signed SqlServer assembly. |
| eng/pipelines/**/*.yml (ci-core, build-sqlclient/azure stages, ci-run-tests stage/job, ci-build-nugets, ci-project-build, run-all-tests, test-azure-package job) | Thread new sqlServerArtifactsName/sqlServerPackageVersion parameter and download the SqlServer artifact for package-mode test/build flows. |
paulmedynski
force-pushed
the
dev/paul/sqlclient-package
branch
from
2b54e4e to
da6d01c
Compare
paulmedynski
added
the
DO NOT MERGE
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4292 +/- ##
==========================================
- Coverage 66.50% 64.68% -1.83%
==========================================
Files 284 279 -5
Lines 43301 66219 +22918
==========================================
+ Hits 28796 42831 +14035
- Misses 14505 23388 +8883
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paulmedynski
force-pushed
the
dev/paul/sqlclient-package
branch
from
da6d01c to
5977b22
Compare
paulmedynski
force-pushed
the
dev/paul/sqlclient-package
branch
from
5977b22 to
ccfa6f8
Compare
paulmedynski
force-pushed
the
dev/paul/sqlclient-package
branch
from
ccfa6f8 to
98683d2
Compare
paulmedynski
force-pushed
the
dev/paul/sqlclient-package
branch
from
98683d2 to
b1e3b65
Compare
paulmedynski
changed the base branch from
dev/paul/sql-server-project-refs
to
dev/paul/internals-package-mode
paulmedynski
force-pushed
the
dev/paul/internals-package-mode
branch
2 times, most recently
from
2a46b0a to
2463f9a
Compare
paulmedynski
force-pushed
the
dev/paul/sqlclient-package
branch
from
9015ee3 to
bef42de
Compare
paulmedynski
force-pushed
the
dev/paul/internals-package-mode
branch
from
e91096e to
fd1a2ff
Compare
paulmedynski
force-pushed
the
dev/paul/sqlclient-package
branch
from
c07c795 to
c6bf797
Compare
paulmedynski
removed
the
DO NOT MERGE
- Change -verbosity: to --verbosity for dotnet CLI consistency - Change isInternalBuild comparisons from string 'True' to boolean true
paulmedynski
force-pushed
the
dev/paul/sqlclient-package
branch
from
c6bf797 to
9868788
Compare
|
This reminds me we should be building for a forward release, i.e. published packages should be named as '7.1.0-preview2.xxxxxx' instead of '7.1.0-preview1.xxxxxx'. Once we have bumped up the versioning, we should also start publishing Nightly built packages to an ADO Artifact feed that's available to public as well - in public project. I don't know if running this pipeline in CI would be any help in long term, as Nightly build and publishing will serve its purpose. Overall this pipeline is doing its job well, we just need to come on agreement with versioning bump to happen right after we release something (or with release notes), before the first 'vNext' nightly build is published. |
| type: string | ||
| default: Release | ||
| values: | ||
| - Debug |
There was a problem hiding this comment.
This should not build in debug mode I think.
| include: | ||
| - main | ||
| - internal/main | ||
| always: true |
There was a problem hiding this comment.
Can we omit running this if there were no changes merged in last 24 hours?
Adds a new top-level pipeline at
eng/pipelines/ci/package/sqlclient-package.ymlthat:mainand ADOinternal/mainbranches (batched)packages/directory before buildingbuild.projPack target withReferenceType=PackageTested ADO.Net project runs here:
We can't test Public project runs until this merges, because we can only create new pipelines based on GitHub for YAML files on main.